Update CODEOWNERS to use documentation group [DOC-256]
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure consistency across all doc repos Fixes: [DOC-256](https://hazelcast.atlassian.net/browse/DOC-256)
✅ Deploy Preview for pedantic-goldberg-f76ec1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hasancelik
reviewed
Nov 20, 2024
| @@ -1,3 +1,3 @@ | |||
| # These owners will be the default owners for everything in | |||
| # the repo | |||
| * @Serdaro @rebekah-lawrence @oliverhowell | |||
| * @hazelcast/documentation | |||
There was a problem hiding this comment.
@JackPGreen can we add CN team also?
Suggested change
| * @hazelcast/documentation | |
| * @hazelcast/documentation @hazelcast/cloud-native |
There was a problem hiding this comment.
I have no issue with this, but at the same time I'm not the arbiter of code ownership - just better defining references to the docs team.
There was a problem hiding this comment.
it is not must have, I just want to check it 🙂
hasancelik
approved these changes
Nov 21, 2024
|
@oliverhowell are you able to review, please? |
oliverhowell
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure consistency across all doc repos
Fixes: DOC-256