Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLC Improvements #967

Merged
merged 17 commits into from
Aug 15, 2023
Merged

CLC Improvements #967

merged 17 commits into from
Aug 15, 2023

Conversation

yuce
Copy link
Collaborator

@yuce yuce commented Aug 14, 2023 •
edited
Loading

This PR:

  • Makes the listener binder internal
  • Adds the Cloud.ExperimentalBaseURL config
  • Enables making a NonRetryableError persistent or not
  • Adds ServerVersion method to Connection type.
  • Fixes compact serialization
  • Fixes iteration on SQL result

@yuce yuce requested a review from kutluhanmetin August 15, 2023 08:24
kutluhanmetin
kutluhanmetin previously approved these changes Aug 15, 2023
View reviewed changes
Copy link

@kutluhanmetin kutluhanmetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good!

@yuce yuce requested a review from kutluhanmetin August 15, 2023 12:36
@yuce yuce merged commit e359966 into master Aug 15, 2023
@yuce yuce deleted the clc branch August 15, 2023 20:35
@yuce yuce added this to the 1.4.1 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kutluhanmetin kutluhanmetin kutluhanmetin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@yuce @kutluhanmetin