Crash problem is fixed when an adress is not found in private_to_public map. #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OzanCansel
commented
Dec 29, 2022
OzanCansel
commented
- If network_address_provider cannot translate the adress, translate method throws an exception.
- Unit test is added.
OzanCansel
force-pushed
the
cloud-translate-fix
branch
from
1901378 to
4ea72e0
Compare
|
Linux test FAILed. |
OzanCansel
force-pushed
the
cloud-translate-fix
branch
2 times, most recently
from
79a9e1c to
c9fbe1c
Compare
|
Linux test FAILed. |
1 similar comment
|
Linux test FAILed. |
|
Windows test FAILed. |
ihsandemir
reviewed
Dec 29, 2022
| new spi::impl::discovery::remote_address_provider{ | ||
| []() { return std::unordered_map<address, address>{}; }, true })); | ||
|
|
||
| EXPECT_THROW(connection_manager.get_or_connect(hazelcast::client::member{}), |
There was a problem hiding this comment.
can you put a dummy address instead of empty constructor to be more realistic?
|
Windows test PASSed. |
|
Linux test PASSed. |
OzanCansel
force-pushed
the
cloud-translate-fix
branch
from
c9fbe1c to
b2f788c
Compare
ihsandemir
previously approved these changes
Dec 29, 2022
|
Windows test FAILed. |
OzanCansel
force-pushed
the
cloud-translate-fix
branch
from
b2f788c to
e2e8ca1
Compare
|
Linux test PASSed. |
|
Windows test PASSed. |
|
Linux test PASSed. |
ihsandemir
approved these changes
Dec 30, 2022
OzanCansel
added a commit
to OzanCansel/hazelcast-cpp-client
that referenced
this pull request
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.