Fix chart update workflow #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semihbkgr
reviewed
Jul 10, 2023
| @@ -98,22 +98,30 @@ jobs: | |||
| echo "HZ_LATEST_TAG=${HZ_LATEST_TAG}" >> $GITHUB_ENV | |||
| echo "MC_LATEST_TAG=${MC_LATEST_TAG}" >> $GITHUB_ENV | |||
|
|
|||
| if [[ $HZ_LATEST_TAG != $APP_VERSION ]]; then | |||
| if [[ $HZ_LATEST_TAG != $APP_VERSION && $MC_LATEST_TAG != $MC_VERSION ]]; then | |||
There was a problem hiding this comment.
Is it correct to use && operator in this condition? The condition will be true when the new version of both Hazelcast and ManagementCenter are released.
There was a problem hiding this comment.
@semihbkgr Yes, it is correct :)
Shortly there are 3 conditions:
- If HZ and MC tags appear => increase the chart version based on the HZ version => and change the HZ and MC versions everywhere.
- If the HZ tag appeared => increase the chart version based on the HZ version => and change the HZ versions everywhere.
- If the MC tag appeared => increase the chart version based on the MC version => and change the MC versions everywhere.
hasancelik
requested review from
cagric0 and
hasancelik
and removed request for
hasancelik and
cagric0
hasancelik
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated chart-update.yml workflow. Now the chart version will be updated even if the new Management center was released