-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kubernetes #88
Conversation
a918929
to
483341b
Compare
Initial version done. You can do Right now, a Jolokia app needs to disable SSL client auth (i.e. @astefanutti Please have a look if you're not on holiday yet. |
I forgot to add one more step to make it really work on a pure k8s cluster. Currently the I intend to make the form-based auth work on both OpenShift and k8s. At this moment, you can try it on OpenShift. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome!
The major area I see that remains is smoothing the user experience, in terms of configuration and documentation.
For the configuration, I can think of:
- Having a Kustomize configuration for vanilla Kubernetes
- Having an extra overlay for OpenShift (and maybe removing the existing resources at the project root)
- Deciding how to handle HTTPS serving or not:
- We can go for documenting manual generation of the serving certificate
- Or for relying on https://cert-manager.io/
For the documentation, I can think of:
- Updating the README to reflect that PR work
- Adding a section on how to create a ServiceAccount and retrieve its token to be used in the form login
Thanks for your feedback! I'll tackle the remaining items from your feedback in a separate issue. |
Thank you for this awesome work! |
#23
Still work in progress. Do not merge.Initial version done.