Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes #88

Merged
merged 11 commits into from
Dec 17, 2021
Merged

Support Kubernetes #88

merged 11 commits into from
Dec 17, 2021

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Dec 7, 2021

#23

Still work in progress. Do not merge.
Initial version done.

@tadayosi
Copy link
Member Author

tadayosi commented Dec 9, 2021

Now the Online console pod discovery works. Next I'll fix the Integration console.

Screenshot from 2021-12-09 15-46-09

@tadayosi tadayosi changed the title WIP - Support Kubernetes Support Kubernetes Dec 16, 2021
@tadayosi
Copy link
Member Author

Initial version done.

You can do yarn deploy:k8s to deploy a hawtio-online instance to k8s cluster.

Right now, a Jolokia app needs to disable SSL client auth (i.e. protocol=https,useSslClientAuthentication=false) to get it connected because service-ca is not available for k8s.

@astefanutti Please have a look if you're not on holiday yet.

@tadayosi
Copy link
Member Author

I forgot to add one more step to make it really work on a pure k8s cluster. Currently the nginx-gateway.conf still depends on hawtio-online-tls-proxying secret which should be removed. I'll push one more commit soon.

I intend to make the form-based auth work on both OpenShift and k8s. At this moment, you can try it on OpenShift.

@astefanutti
Copy link
Contributor

Woot!

A Camel K integration running on Minikube and managed by Hawtio:

Screenshot 2021-12-16 at 11 04 42

Screenshot 2021-12-16 at 11 04 51

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome!

The major area I see that remains is smoothing the user experience, in terms of configuration and documentation.

For the configuration, I can think of:

  • Having a Kustomize configuration for vanilla Kubernetes
  • Having an extra overlay for OpenShift (and maybe removing the existing resources at the project root)
  • Deciding how to handle HTTPS serving or not:

For the documentation, I can think of:

  • Updating the README to reflect that PR work
  • Adding a section on how to create a ServiceAccount and retrieve its token to be used in the form login

packages/common/src/openshift/openshift.service.ts Outdated Show resolved Hide resolved
deploy/bases/service.yml Outdated Show resolved Hide resolved
@tadayosi
Copy link
Member Author

Thanks for your feedback! I'll tackle the remaining items from your feedback in a separate issue.

@tadayosi tadayosi merged commit 8d5e36d into hawtio:master Dec 17, 2021
@astefanutti
Copy link
Contributor

Thank you for this awesome work!

@tadayosi tadayosi mentioned this pull request Dec 17, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants