Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption for local storage values #329

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

phantomjinx
Copy link
Member

Provides fixes for the execution of any unit tests in each api package then implements the encryption / decryption of localStorage credentials.

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment to be changed, but otherwise looks good to me.

packages/oauth/src/utils/secure-storage.ts Outdated Show resolved Hide resolved
* Tests not really implemented and ran previously. Adds missing pieces to
  ensure that those tests that have been created are successfully run.

* Corrects the test setup for jest and adds necessary mocks
* crypto.ts
 * Brings in crypto utility functions for encrypting / decrypting strings

* secure-storage.ts
 * Encapsulates crypto functions for securing storage of values into
   local storage

* .../openshift/..., .../form/...
 * Replaces all localStorage calls with secure-storage API
 * Makes those functions that require it asynchronous and employs 'await'
@phantomjinx phantomjinx merged commit 89e9f7c into hawtio:main Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants