fix: Move online-shell dev env to /online documentBase - #242 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Aligns the online-shell dev server with the production build by making the documentBase of the app /online. * Avoids the problem, reported in hawtio#242, of an invalid double-slash url since the documentBase is identified as /online. * hawtconfig.json * Corrects urls for hawtio-logo not showing up correctly in dev with documentBase but still showing up correctly in production * webpack.config.common.js * Does not effect production but make publicPath always /online regardless of mode * webpack.config.dev.js * Modifies output and static to include the publicPath * Updates the osconsole url which is the only path relative in the code base so needs the publicPath prepended
tadayosi
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the online-shell dev server with the production build by making the documentBase of the app /online.
Avoids the problem, reported in Can no longer connect to jolokia urls in online-shell dev server #242, of an invalid double-slash url since the documentBase is identified as /online.
hawtconfig.json
webpack.config.common.js
webpack.config.dev.js