Upgrade node 18 #198
Merged
Upgrade node 18 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* By default webpack resolve/modules contains the placeholder 'node_modules' which recursively checks each dependency for their own node_modules directory. The current config does not contain this so no recursive resolution occurs. * No need for the override at all so removing from all webpack configs
tadayosi
reviewed
Nov 20, 2023
* Upgrades type/node to 18.18.9 * The upgrade of type/node causes an incompatibility with the overriding of fetch where the API is verbose and difficult to patch. As we are simply wanting an interceptor to supply the authorization header, we can employ fetch-intercept instead. This registers a function that jumps in front of the request before it is sent, allowing the auth header to be added. * Supercedes PR hawtio#190
phantomjinx
force-pushed
the
upgrade-node-18
branch
from
4db3fd5
to
7ec706a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes chore(deps): bump @types/node from 18.18.6 to 18.18.9 #190 and ensures that code compiles correctly by changing the monkey patching of window.fetch to a fetch intercepter.
Supercedes Depedency upgrades #197 by breaking down into requisite concerns.