Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update yarn to 3.6.1 and hold yarn in repo #142

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

tadayosi
Copy link
Member

My first contribution to 2.x. @phantomjinx Please have a look.

  • Upgrade to Yarn 3.6.1 (latest stable).
  • Copy yarn 3.6.1 and plugin under .yarn/ as otherwise builds cannot be portable among developers.

*/ in .gitignore is intentionally deleted. As far as I remember, it was added to avoid copying unnecessary files to the docker build image but now we have .dockerignore and I'm not sure if this entry was really needed. Let's revisit it when we are to build a docker image for hawtio-online v2.

* Upgrade to Yarn 3.6.1 (latest stable).
* Copy yarn 3.6.1 and plugin under .yarn/ as otherwise builds cannot be
  portable among developers.

`*/` in .gitignore is intentionally deleted. As far as I remember, it
was added to avoid copying unnecessary files to the docker build image
but now we have .dockerignore and I'm not sure if this entry was really
needed. Let's revisit it when we are to build a docker image for
hawtio-online v2.
Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phantomjinx phantomjinx merged commit 52ae572 into hawtio:2.x Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants