Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: cleanup docs #51

Merged
merged 5 commits into from
Oct 23, 2020
Merged

doc: cleanup docs #51

merged 5 commits into from
Oct 23, 2020

Conversation

erisu
Copy link

@erisu erisu commented Oct 22, 2020

Description

Cleanup docs to fit this repo & plugin

Related Issue

n/a

Motivation and Context

Cleanup with accurate information

How Has This Been Tested?

n/a

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix/Refactor/Docs (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu requested a review from jcesarmobile October 22, 2020 13:53
jcesarmobile
jcesarmobile requested changes Oct 22, 2020
View reviewed changes
Copy link

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment

and the whole #### minSdkVersion === 14 section can be removed since cordova-android 8 had minSdk 19

docs/INSTALLATION.md Outdated Show resolved Hide resolved
@erisu @jcesarmobile
doc: Update docs/INSTALLATION.md
de93c3c 
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
@erisu erisu requested a review from jcesarmobile October 22, 2020 16:11
jcesarmobile
jcesarmobile approved these changes Oct 22, 2020
View reviewed changes
Copy link

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit ea8ea28 into master Oct 23, 2020
@erisu erisu deleted the doc/cleanup branch October 23, 2020 03:53
@erisu erisu restored the doc/cleanup branch October 23, 2020 03:53
@erisu erisu deleted the doc/cleanup branch October 23, 2020 03:53
@erisu erisu mentioned this pull request Oct 23, 2020
Closed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @jcesarmobile