Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all Firebase exceptions #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxs15
Copy link

@maxs15 maxs15 commented Jan 13, 2025

Description

This PR aims to catch all exceptions that could be thrown by the Firebase SDK.

Related Issue

#340

Motivation and Context

This change allows us to catch all exceptions, thus eliminating potential crashes. Since deploying this code in production, all crashes have been resolved.

How Has This Been Tested?

This code has been tested in local and deployed in production.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant