Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): clipped notification text and expand arrow #286

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

erisu
Copy link

@erisu erisu commented Aug 31, 2024

Description

Fixes the issue where the notification was being clipped and the expand arrow was displayed.

Related Issue

Fixes #263
Closes #268

Motivation and Context

Resolves above issues

How Has This Been Tested?

Tested on Android SDK 24 & 34

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu merged commit 84731dd into master Aug 31, 2024
7 checks passed
@erisu erisu deleted the fix/GH-263 branch August 31, 2024 06:13
@erisu erisu added the ios Related to the iOS platform label Nov 13, 2024
@erisu erisu added this to the 5.0.0 milestone Nov 13, 2024
@erisu erisu added android Related to the Android platform and removed ios Related to the iOS platform labels Nov 13, 2024
Copy link

github-actions bot commented Dec 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
android Related to the Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arrow to expand notification preview in notifications bar
2 participants