Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short search strings take a long time #15

Closed
haukex opened this issue Jul 28, 2024 · 2 comments
Closed

Short search strings take a long time #15

haukex opened this issue Jul 28, 2024 · 2 comments
Assignees
@haukex
Labels
bug Something isn't working

Comments

@haukex
Copy link
Owner

haukex commented Jul 28, 2024

For example, "e" takes up to 5s on my machine, and "ea" takes ~1s.

Restrict search string length, or show spinner? Other optimizations possible?
@haukex haukex added the bug Something isn't working label Jul 28, 2024
haukex added a commit that referenced this issue Jul 28, 2024
@haukex
Minor optimization in equiv.ts
007bd73 
This was to see if this might improve issue #15, but it only sped up the
search fore.g. "e" slightly but not significantly.
@haukex
Copy link
Owner Author

haukex commented Jul 29, 2024 •
edited
Loading

I'm currently leaning towards simply not performing one-character searches; the delay on two-character searches is still acceptable IMHO.

@haukex haukex self-assigned this Aug 10, 2024
@haukex haukex closed this as completed in d9b58f9 Aug 10, 2024
haukex added a commit that referenced this issue Sep 8, 2024
@haukex
[WIP worker] Minor updates
5054c4d 
Mostly moved some code around.

Just to have it noted somewhere: The reason I'm rewriting the search to
use a Web Worker is for issue #15 (short search strings) and issue #26
(wildcard search), both of which take a long time and would otherwise
block the main UI thread.
@haukex
Copy link
Owner Author

haukex commented Sep 27, 2024 •
edited
Loading

Since I merged the Web Worker branch in 2c3bb38, short search strings are now allowed again because slow searches now display a progress bar instead of blocking the browser.

Edit: Since the branch info is no longer available: the worker branch was 5ea4fc4…2c3bb38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haukex haukex

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haukex