Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed Events #418

Merged
merged 20 commits into from
Oct 12, 2022
Merged

Typed Events #418

merged 20 commits into from
Oct 12, 2022

Conversation

IanSSenne
Copy link
Contributor

Typed events #395

hathora.yml:

types:
  SomeType:
    foo: string
events:
  myEvent: SomeType
  myOtherEvent: number

api types:

enum HathoraEvents{
  myEvent,
  myOtherEvent,
}

server:

ctx.sendEvent(HathoraEvents.myEvent, {foo: "bar"}, userId)

client:

export type HathoraEvent = {type: HathoraEvent.myEvent; val: SomeType} | {type: HathoraEvent.myEvent; val: SomeOtherType}

hpx7
hpx7 reviewed Oct 12, 2022
View reviewed changes
templates/base/api/base.ts.hbs Outdated
export type Message = ResponseMessage | EventMessage;
export const Message: {
response: (msgId: number, response: Response) => ResponseMessage;
event: (event: string) => EventMessage;
event: (event: T.HathoraEventTypes, data: any) => EventMessage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is data of type any here?

hpx7
hpx7 reviewed Oct 12, 2022
View reviewed changes
templates/base/api/types.ts.hbs Outdated
{{#each events}}
case HathoraEventTypes.{{@key}}:{
const x = event.data as HathoraEventPayloads[HathoraEventTypes.{{@key}}];
buf.writeUVarint(HathoraEventTypes.{{@key}});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be moved up before the switch statement?

hpx7
hpx7 reviewed Oct 12, 2022
View reviewed changes
src/generate.ts Outdated Show resolved Hide resolved
@IanSSenne IanSSenne requested a review from hpx7 October 12, 2022 21:04
@hpx7 hpx7 merged commit 3715bda into hathora:develop Oct 12, 2022
@hpx7 hpx7 mentioned this pull request Oct 18, 2022
Closed
kasbah pushed a commit to kasbah/hathora-builder that referenced this pull request Jan 15, 2023
@IanSSenne @hpx7 @kasbah
Typed Events (hathora#418)
ae47842 
* type gen completed

* more type generations

* first implimentation, tested with simple events

* cleanup unused handlbars helpers

* fix whitespace

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/client/.hathora/client.ts.hbs

* Update src/generate.ts

* requested pr changes

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/types.ts.hbs

* Update templates/base/api/base.ts.hbs

* Apply suggestions from code review

Co-authored-by: Ian Senne <ianssenne@gmail.com>
Co-authored-by: Harsh Pandey <hpandey793@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpx7 hpx7 hpx7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanSSenne @hpx7