Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in writing SysEx messages. #512

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Commits on Sep 13, 2020

  1. Update midi_device.c

    Fix a bug in writing SysEx messages.
    
    At the start of a new USB packet (4 bytes), while in the middle of a SysEx, the code mistakenly
    set the buffer length to 4, not the target length. As a consequence, the 3rd and 4th bytes from
    the last packet were included, after every byte of the SysEx after the first packet of three.
    
    The fix is simple, as it was just a typo, as can bee seen from the other branches in the same
    section of if/else statements: At the start of a new packet, the code should set up the target
    length... the buffer length should be left at 2 (as set on line 180).
    mzero authored Sep 13, 2020
    Configuration menu
    Copy the full SHA
    3b0216d View commit details
    Browse the repository at this point in the history