Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style improvements found by cppcheck #2766

Closed
wants to merge 8 commits into from
Closed

Conversation

dp111
Copy link
Contributor

@dp111 dp111 commented Aug 16, 2024

Minor style improvements found by cppcheck.

@HiFiPhile
Copy link
Collaborator

Thank you for the PR, but we are not interested for these variable name changing, for example buffer is used elsewhere.

@dp111
Copy link
Contributor Author

dp111 commented Sep 1, 2024

Just so I know are you interested in the function prototypes matching the functions ? Would you like to cherry pick the break; to be inside the #if ?

@HiFiPhile
Copy link
Collaborator

Just so I know are you interested in the function prototypes matching the functions ?

Could you elaborate, is there any mismatched prototype ?

Would you like to cherry pick the break; to be inside the #if ?

Yes please.

@dp111
Copy link
Contributor Author

dp111 commented Sep 1, 2024

In tusb_fifo.h we currently have :
bool tu_fifo_read(tu_fifo_t* f, void * p_buffer);
in tusb_fifo.c :
bool tu_fifo_read(tu_fifo_t* f, void * buffer)

This is super minor but the PR intended to make the second parameter match.

@HiFiPhile
Copy link
Collaborator

In tusb_fifo.h we currently have :
bool tu_fifo_read(tu_fifo_t* f, void * p_buffer);
in tusb_fifo.c :
bool tu_fifo_read(tu_fifo_t* f, void * buffer)

Didn't notice that, please change the prototype to use buffer since it's more used.

Speaking of which the project doesn't have a naming convention yet...

@dp111 dp111 closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants