rgifford/pla assessment #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic for posting a new message was not properly updating state. I updated it so rather than mutating the current data, state is now updated when a message is created.
I added a
seenproperty to the Message schema, to indicate unread messages.I also added a useEffect to update messages in conversations as read when the conversation is opened.
Notes on your approach and thought process
I could tell that the initial bugs were state related because the correct values would appear after a refresh. I've personally seen this issue within React many times.
I also implemented a bulk update for reading messages based on if a conversation is opened. If a conversation is opened, all the messages are read.