Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added click and olefile to requirements.txt #8

Closed
wants to merge 1 commit into from

Conversation

idiom
Copy link

@idiom idiom commented Feb 14, 2017

Added the click and olefile packages to the requirements.txt for easy pip deployment during development.

@jbremer
Copy link
Member

jbremer commented Feb 14, 2017

Thanks for that! I wasn't even aware there was still a requirements.txt in this repository, as the dependencies have long moved to setup.py (see also https://github.com/jbremer/sflock/blob/master/setup.py#L28-L30). That said, you can very easily deploy sflock by either running pip install -U sflock or, when developing, python setup.py develop. As such I see no other option then to close this PR and officially remove the requirements.txt from the repository.
If you have any other feedback and/or questions, please do let me know!

@jbremer jbremer closed this Feb 14, 2017
jbremer added a commit that referenced this pull request Feb 14, 2017
@coveralls
Copy link

coveralls commented Feb 14, 2017

Coverage Status

Coverage remained the same at 92.807% when pulling 10ef8dd on idiom:master into 9713b64 on jbremer:master.

psrok1 pushed a commit to CERT-Polska/sflock that referenced this pull request Apr 6, 2023
…s-encrypted-maldocs

do not fail on encrypted office documents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants