Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contributing): improve onboarding #3

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

steebchen
Copy link
Collaborator

  • shell scripts logging and fail on error
  • use npx --yes instead of manual global install
  • run go libs directly instead of installing and running binaries
  • add missing brew dependencies

- shell scripts logging and fail on error
- use npx --yes instead of manual global install
- run go libs directly instead of installing and running binaries
- add missing brew dependencies
@steebchen steebchen requested a review from abelanger5 December 18, 2023 17:52
Copy link
Contributor

@abelanger5 abelanger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@abelanger5 abelanger5 merged commit 6fef81e into main Dec 18, 2023
@steebchen steebchen deleted the chore/contributing branch December 19, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants