feat(repository): use generic cacheable function #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steebchen
changed the title
steebchen
changed the title
abelanger5
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Yeah this is kinda nice, I like this. I do think we should be careful of using the IDs in the cache and potentially setting a different cache per resource. There are a handful of IDs in the database who are uniquely keyed on tuples like (tenantId, actionId) for example. It would be easy to misuse this and start accidentally poisoning the cache.
steebchen
force-pushed
the
feat/repository-cache
branch
from
a7a7995 to
d5b231a
Compare
steebchen
force-pushed
the
feat/repository-cache-generic
branch
from
8559aeb to
6667919
Compare
steebchen
force-pushed
the
feat/repository-cache-generic
branch
from
ab37253 to
8179746
Compare
steebchen
force-pushed
the
feat/repository-cache-generic
branch
from
8179746 to
8559aeb
Compare
steebchen
force-pushed
the
feat/repository-cache
branch
from
673d57f to
6946884
Compare
steebchen
force-pushed
the
feat/repository-cache-generic
branch
from
5ccbbfb to
14e599c
Compare
steebchen
force-pushed
the
feat/repository-cache
branch
from
ea898c7 to
fa3166e
Compare
abelanger5
approved these changes
Mar 19, 2024
| @@ -18,6 +18,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestMessageQueueIntegration(t *testing.T) { | |||
| t.SkipNow() | |||
There was a problem hiding this comment.
Why are we skipping these tests?
There was a problem hiding this comment.
somehow these tests fail on my machine. pushed this by accident, good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
What's Changed