fix: hangup workflow listener when workflow run finishes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grutt
requested changes
Feb 9, 2024
| print('failure stopping listener...') | ||
| break | ||
|
|
||
| if payload and stop_step and stop_step in payload and eventType != StepRunEventType.STEP_RUN_EVENT_TYPE_STARTED: |
There was a problem hiding this comment.
oops, might want to remove this block now that we have signaling and hangups.
| if workflow_event.eventPayload: | ||
| payload = json.loads(workflow_event.eventPayload) | ||
|
|
||
| # TODO: eventually call a handler here |
There was a problem hiding this comment.
rm comment, this is handled in the on method
grutt
approved these changes
Feb 9, 2024
steebchen
added a commit
that referenced
this pull request
Feb 12, 2024
This reverts commit f8e9c8b.
grutt
added a commit
that referenced
this pull request
Feb 13, 2024
* hotfix: add repository for npm publish * release(py-sdk): bump version * chore: ignore venv * feat(dashboard): collapsible sidebar * fix: hangup workflow listener when workflow run finishes (#161) * wip: class based listener pattern * fix: workflow run listener hangups * fix: hang up workflow listener on finished * fix: case for current workflow run * address review comments * bump version --------- Co-authored-by: g <gabriel.ruttner@gmail.com> * wip: focus state and flat playground * fix: focus state * feat: unify state * wip: playground state * cleanup: rm logging * fix: default output * cleanup: rm deadcode * feat: can replay individual steps * feat: icon tabs * feat: sticky output * cleanup: linting --------- Co-authored-by: abelanger5 <belanger@sas.upenn.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listeners rely on client-side cancellation to hang up. This hangs up the listener if the workflow run finishes.
Type of change
Please delete options that are not relevant.
What's Changed