breaking: drop id from event_triggers table (fix #1840)

[tirumaraiselvan]

Description

An auto-generated trigger_id was being generated for each event_trigger. This trigger_id was causing problems as described in #1840 . We solve this by removing the trigger_id and using trigger_name as the identifier for the event_trigger everywhere.

Affected components

• Server
• Console
• Docs

Related Issues

#1840

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

This change is breaking in the following way:

• There will no longer be an id key in the trigger section of the event payload i.e.

  "trigger": {
      "name": "<name-of-trigger>",
      "id": "<uuid>"
  }

changes to:

  "trigger": {
      "name": "<name-of-trigger>"
  }

[netlify]

Deploy preview for hasura-docs ready!

Built with commit 81fe166

https://deploy-preview-1857--hasura-docs.netlify.com

[hasura-bot]

Review app for commit 417113e deployed to Heroku: https://hge-ci-pull-1857.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1857-417113e

[rikinsk-zz]

Fix Pending events page.

Breaks if you delete a trigger and then re-add it with another name.

edit: happens if you just create a trigger on a table/action that is already part of another trigger

[tirumaraiselvan]

Check invocation logs page as well.

[hasura-bot]

Review app for commit 81fe166 deployed to Heroku: https://hge-ci-pull-1857.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1857-81fe166

[hasura-bot]

Review app https://hge-ci-pull-1857.herokuapp.com is deleted

[danielcompton]

Thanks, I've verified this patch fixes our issues.