Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console: retry configuration editing is broken #1975

Closed
MathiasGr opened this issue Apr 10, 2019 · 0 comments
Closed

Console: retry configuration editing is broken #1975

MathiasGr opened this issue Apr 10, 2019 · 0 comments

Comments

@MathiasGr
Copy link
Contributor

On the latest release, trying to update the events' retry settings leads to this error:

Updating trigger failed
expected Int, encountered String

After looking at the Network logs, I found out the num_retries, interval_sec and timeout_sec variables are being sent as Strings. Here's an example when updating the num_retries:

{
    "retry_conf":{"num_retries":"10","interval_sec":10,"timeout_sec":60}
}

It turns out the proper validation that uses parseInt to turn the input strings into ints was coded but never used anywhere in the code.

I'm submitting a PR right away to properly call the validateAndSave method
MathiasGr added a commit to bigbluedisco/graphql-engine that referenced this issue Apr 10, 2019
@MathiasGr
validate input in console's retry config editor, fix hasura#1975
b4b7caa
@MathiasGr MathiasGr mentioned this issue Apr 10, 2019
Merged
wawhal pushed a commit to wawhal/graphql-engine that referenced this issue Apr 11, 2019
@MathiasGr @wawhal
fix save function in console's retry config editor (fix hasura#1975) (h…
9971e9f 
…asura#1976)
tirumaraiselvan pushed a commit to tirumaraiselvan/graphql-engine that referenced this issue Apr 11, 2019
@wawhal @tirumaraiselvan
remote relationship support for console (#5)
684464d 
* added feedback on migration commands (close hasura#1410) (hasura#1931)

* firebase2graphql (v0.0.2): support array types in firebase json (close hasura#1829) (hasura#1900)

* improve console error page (close hasura#272) (hasura#1890)

* add nextjs 8 jwt sample app (hasura#1943)

* persist queries in GraphiQL (closes hasura#1894) (hasura#1903)

* add realtime chat sample app with vue (hasura#1885)

* fix update_event_trigger query not persisting the changes (hasura#1950)

fix hasura#1949

* mention required key length for HMAC encryption to user (hasura#1956)

Following on from a discussion in discord, a small tweak to make the required key length for a HMAC key more obvious

* fix input argument types for custom SQL functions (close hasura#1952) (hasura#1953)

* run graphql tests on both http and websocket; add parallelism (close hasura#1868) (hasura#1921)

Examples 
1)  `
pytest --hge-urls "http://127.0.0.1:8080" --pg-urls "postgresql://admin@127.0.0.1:5432/hge_tests" -vv
`
2)  `pytest --hge-urls "http://127.0.0.1:8080"   "http://127.0.0.1:8081" --pg-urls "postgresql://admin@127.0.0.1:5432/hge_tests"  "postgresql://admin@127.0.0.1:5432/hge_tests2" -vv
`
### Solution and Design
<!-- How is this issue solved/fixed? What is the design? -->
<!-- It's better if we elaborate -->
#### Reducing execution time of tests
- The Schema setup and teardown, which were earlier done per test method, usually takes around 1 sec. 
- For mutations, the model has now been changed to only do schema setup and teardown once per test class.
-  A data setup and teardown will be done once per test instead (usually takes ~10ms).
- For the test class to get this behaviour, one can can extend the class `DefaultTestMutations`. 
    - The function  `dir()` should be define which returns the location of the configuration folder.
    - Inside the configuration folder, there should be 
        - Files `<conf_dir>/schema_setup.yaml` and `<conf_dir>/schema_teardown.yaml`, which has the metadata query executed during schema setup and teardown respectively
        - Files named `<conf_dir>/values_setup.yaml` and `<conf_dir>/values_teardown.yaml`. These files are executed to setup and remove data from the tables respectively. 

#### Running Graphql queries on both http and websockets
- Each GraphQL query/mutation is run on the both HTTP and websocket protocols
- Pytests test parameterisation is used to achieve this
- The errors over websockets are slightly different from that on HTTP
   - The code takes care of converting the errors in HTTP to errors in websockets

#### Parallel executation of tests.
- The plugin pytest-xdist helps in running tests on parallel workers.
- We are using this plugin to group tests by file and run on different workers.
- Parallel test worker processes operate on separate postgres databases(and separate graphql-engines connected to these databases). Thus tests on one worker will not affect the tests on the other worker.
- With two workers, this decreases execution times by half, as the tests on event triggers usually takes a long time, but does not consume much CPU.

* update manifests to v1.0.0-alpha42

* update regex to delete event triggers in edit-pg-dump (close hasura#1959) (hasura#1960)

* support composite foreign keys and primary keys through console (close hasura#1707) (hasura#1854)

* edit-pg-dump: fix a missing semi-colon

* fix styles in browse rows, relationship and permission tables (hasura#1969)

* update console permissions ui (hasura#1924)

* Make permissions sections as collapsibles with tooltips
* Remove 'use same permission as select' type options from row permissions section
* Added clone section to apply same permission to any table-role-action
* Disable other subsections till row permissions are set

* re-add same as other action options in permissions (hasura#1970)

* fix excessive memory consumption with bulk queries (hasura#1972)

Use 'Strict' State monad instead of 'Lazy' to avoid unevaluated memory thunks

* add placeholder for bool type fields while inserting rows (hasura#1962)

* Use UTF-8 encoding for stack hpc report generation (hasura#1974)

* fix save function in console's retry config editor (fix hasura#1975) (hasura#1976)

* Wip

* add scroll to literal blocks in docs (close hasura#1954) (hasura#1978)

* remote relationship ui v1

* wip

* ui for creating remote relationships

* wip

* ui fixes

* ui fixes

* functional ui

* namespace ui wip

* add functionality for dropping relationship

* show exact error in notification

* fix state inconsistencies

* update reldef for namespaced fields

* lint
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
@MathiasGr @polRk
fix save function in console's retry config editor (fix hasura#1975) (h…
35f0e94 
…asura#1976)
@jpda jpda mentioned this issue May 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MathiasGr