Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tailscale's builtin inbound HTTPS proxy #137

Merged
merged 4 commits into from
Apr 29, 2023

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Jan 18, 2023

Replaces PR #89 #134

Proposed Changes

This is a better solution to the #62 issue than #89 #134 because it doesn't need any manual configuration and also provides a built-in proxy for the https traffic. We don't need to refresh the certificates manually, this is all done by tailscale automatically.

Related Issues

Fixes #62

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 9, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Mar 9, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Mar 10, 2023
@lmagyar lmagyar force-pushed the enable-tailscale-builtin-proxy branch from 6abd150 to 7ec02a8 Compare March 15, 2023 21:17
@lmagyar
Copy link
Contributor Author

lmagyar commented Mar 15, 2023

I force pushed a rebase onto the lates PR #133, because with tailscale 1.38.1 some script changes are required. So this PR works only after that is merged.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR references a lot, but it doesn't describe what it does.

LICENSE.md Outdated Show resolved Hide resolved
@frenck frenck added the new-feature New features or options. label Mar 28, 2023
@lmagyar lmagyar force-pushed the enable-tailscale-builtin-proxy branch from 7ec02a8 to 7d8c03c Compare March 28, 2023 11:43
@lmagyar
Copy link
Contributor Author

lmagyar commented Mar 28, 2023

I stashed and rebased it.

This is an optional functionality, if the user doesn't configure anything, it works as previously, but emits some info log messages, that it can be configured and used.

If configured, this solves the unsecure connection problem (I know, it's secure, only the browsers have problem with it): downloads and regularly refreshes a tailscale certificate for our tailnet and fires up it's own built-in proxy.

@lmagyar
Copy link
Contributor Author

lmagyar commented Mar 28, 2023

I tried to keep this add-on as zero-config as it was, all the configuration is done on the tailscale admin web UI.

tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
@lmagyar lmagyar force-pushed the enable-tailscale-builtin-proxy branch from 7d8c03c to 3bd3da5 Compare April 1, 2023 10:03
@lmagyar lmagyar changed the title Enable Tailscale's builtin https proxy Enable Tailscale's builtin HTTPS proxy Apr 1, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Apr 1, 2023

I've rebased and rewritten as requested.

Also tested manually the proxy startup logic and some corner cases on real devices.

@MelleD
Copy link

MelleD commented Apr 2, 2023

@lmagyar I'm looking forward to the PR 👍

@lmagyar lmagyar changed the title Enable Tailscale's builtin HTTPS proxy Enable Tailscale's builtin inbound HTTPS proxy Apr 3, 2023
@MelleD
Copy link

MelleD commented Apr 4, 2023

@frenck Do you think it's possible to do a (beta) release this week?

I would/could test it over the long Easter weekend :)

@frenck
Copy link
Member

frenck commented Apr 4, 2023

@MelleD Not sure, right now, the Home Assistant Core release has my priority this week.

@lmagyar
Copy link
Contributor Author

lmagyar commented Apr 4, 2023

Do you think it's possible to do a (beta) release this week?
I would/could test it over the long Easter weekend :)

@MelleD You can test it with installing my forked repo, more test is better: https://github.com/lmagyar/homeassistant-addon-tailscale

@MelleD
Copy link

MelleD commented Apr 4, 2023

Do you think it's possible to do a (beta) release this week?
I would/could test it over the long Easter weekend :)

@MelleD You can test it with installing my forked repo, more test is better: https://github.com/lmagyar/homeassistant-addon-tailscale

Ok great, I'll try that 👍

@lmagyar lmagyar force-pushed the enable-tailscale-builtin-proxy branch from e802721 to 91b849a Compare April 5, 2023 01:56
@MelleD
Copy link

MelleD commented Apr 6, 2023

Short feedback:
Works for me and enabled it. Thanks a bunch

@lmagyar lmagyar force-pushed the enable-tailscale-builtin-proxy branch from 91b849a to 8b0eb07 Compare April 27, 2023 18:43
@lmagyar
Copy link
Contributor Author

lmagyar commented Apr 27, 2023

FYI:

  • I've squashed and rebased the PR.
  • Added a taildrop like optional bool? configuration option to disable it in case somebody has any issues with it.

The "how to make it customizable" review is still relevant/open.

I also plan to PR the Funnel feature after this PR settled.

tailscale/translations/en.yaml Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
tailscale/DOCS.md Outdated Show resolved Hide resolved
@lmagyar lmagyar force-pushed the enable-tailscale-builtin-proxy branch from c5f6fb3 to 134e5ee Compare April 29, 2023 12:01
@lmagyar
Copy link
Contributor Author

lmagyar commented Apr 29, 2023

FYI:

  • I've accepted everything you suggested
  • I've found another "device" -> "instance" replacement in DOCS.md
  • Rebased to the latest main branch

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit f7c0a5e into hassio-addons:main Apr 29, 2023
@lmagyar lmagyar deleted the enable-tailscale-builtin-proxy branch April 29, 2023 13:43
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPS Support
4 participants