Basic explanation of 59692 #534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,10 @@ | |||
| --- | |||
| title: Duplicate instance declarations | |||
| summary: An instance has been defined twice for the same type. | |||
There was a problem hiding this comment.
It's not necessarily exactly twice, is it? A more precise way to describe this would be, perhaps:
Suggested change
| summary: An instance has been defined twice for the same type. | |
| summary: An instance of a class has been defined once again for the same type. |
There was a problem hiding this comment.
"once again" makes it sound like there was an instance in the past and now there is one once again. Perhaps just "multiple times" instead of "twice" then.
There was a problem hiding this comment.
But for the compiler, there was an instance that it saw in the past, only it's very close past: maybe in the same .hs file (but maybe not). So, I don't see a problem here. But "multiple times" works for me too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.