Bump up ghcide submodule to version 0.5.0

[jneira]

• To get support for CPP/LHS preprocessing in the Eval plugin.

[jneira]

To avoid

src\Ide\Plugin\Tactic.hs:310:15: error:
    • Overlapping instances for Show
                                  (GenLocated SrcSpan (HsExpr GhcPs))
        arising from a use of ‘traceMX’
      Matching instances:
        instance Outputable.Outputable a => Show (GenLocated SrcSpan a)
          -- Defined in ‘ghcide-0.4.0:Development.IDE.GHC.Orphans’
        instance Show (LHsExpr GhcPs)
          -- Defined at src\Ide\Plugin\Tactic\Types.hs:68:10
    • In the expression: traceMX "solns"
      In a stmt of a 'do' block: traceMX "solns" $ rtr_other_solns rtr
      In the expression:
        do traceMX "solns" $ rtr_other_solns rtr
           let g = graft (RealSrcSpan span) $ rtr_extract rtr
               response = transform dflags (clientCapabilities lf) uri g pm
           pure
             $ case response of
                 Right res -> (Right Null, Just ...)
                 Left err
                   -> (Left $ ResponseError InternalError (T.pack err) Nothing,
                       Nothing)
    |
310 |               traceMX "solns" $ rtr_other_solns rtr
    |               ^^^^^^^^^^^^^^^

[wz1000]

I think you can just delete this?

[jneira]

I tried to delete the ghcide instance and it throwed an error, will doublechek
or do you mean the tactic instance?

[wz1000]

I mean the HLS instance.

[jneira]

removing it it throws:

src\Ide\Plugin\Tactic\Types.hs:368:14: error:
    • No instance for (Show (LHsExpr GhcPs))
        arising from the second field of ‘RunTacticResults’
          (type ‘LHsExpr GhcPs’)
      Possible fix:
        use a standalone 'deriving instance' declaration,
          so you can specify the instance context yourself
    • When deriving the instance for (Show RunTacticResults)
    |
368 |   } deriving Show
    |              ^^^^

It uses the instance in other context.

---

I dont fullt understand why they overlap

For
Show (GenLocated SrcSpan (HsExpr GhcPs))

instance Outputable.Outputable a => Show (GenLocated SrcSpan a)
and
instance Show (LHsExpr GhcPs)

[jneira]

pr opened (with the branch in the main repo just in case): haskell/ghcide#894

[wz1000]

I'm sure the instances are exported through some other module? You just have to import that.

[jneira]

Ok will check what module reexports them

[jneira]

It turns out that several modules export those instances, as @wz1000 anticipated.
Of all of them i have chose Development.IDE (), the more generic, cause import a specific module (for example Development.Ide.Core.Sahe) only for instances does not look sensible.

However i would use Development.IDE.GHC.Orphans if it is visible cause the intent of the import is clearer, so i would keep the pr exporting it opened. We will can use it here afterwards in hls.

[ndmitchell]

Agreed - importing Orphans is much clearer.

[jneira]

Updated ghcide to version 0.5.0 and use the now public Development.IDE.GHC.Orphans

[jneira]

@wz1000 could it be merged as is?

[wz1000]

Yeah, looks good