Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tactic subpackage in default stack.yaml #529

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 23, 2020

  • It is not being built in ci (cause it is identical to stack-8.6.5.yaml) 🤔

@jneira jneira requested a review from isovector October 23, 2020 06:44
Copy link
Collaborator

@isovector isovector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jneira jneira merged commit c499f6b into master Oct 23, 2020
@jneira jneira deleted the fix-stack-yaml branch October 23, 2020 09:01
@isovector
Copy link
Collaborator

Does it make sense to exclude stack.yaml from source control? The reason I missed this is that I have my copy ignoring changes, since I want to use a different resolver. If it's not being built in CI either I think we should just remove it and have users choose one.

@jneira
Copy link
Member Author

jneira commented Oct 23, 2020

mmm well i suppose beginners had to do one more step in that case.
It could a way to signal what is the "default" resolver to build the project, the one that should work for the largest number of use cases.
But that make everyone else to set explicitly the stack yaml so i understand your point.
If we keep it i would add it to ci, to avoid let it not synchronized and cause not always will be equivalent to another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants