Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #2734
Brief intro:
With
it will suggest import
Foo(..)
now, likeimport A(Foo(..))
andAdd Foo(..) to the import list of A
.Note:
Support Now!
This doesn't work for record fields, ideally, we should support this.Example:
if we have
f = a
, we should also haveimport A(Foo(..))
. Maybe we can extendhaskell-language-server/ghcide/src/Development/IDE/Types/Exports.hs
Lines 64 to 70 in 621c2bb
with a field to indicate
a
's data type ifa
is a record field.