[Plugin] stylish-haskell formatter #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
Jun 5, 2020
Ailrun
force-pushed
the
stylish-haskell-plugin
branch
from
6f8c980 to
a18cab6
Compare
Ailrun
force-pushed
the
stylish-haskell-plugin
branch
from
a18cab6 to
c61f27a
Compare
|
@fendor Thank you for the review and answer. |
Ailrun
commented
Jun 5, 2020
| \bar (Just (Left _)) = 0\n\ | ||
| \bar (Just (Right x)) = x\n" | ||
| ] | ||
|
|
There was a problem hiding this comment.
While I was writing this, I thought it might be better to add a golden test facility.
Any opinions/ideas?
There was a problem hiding this comment.
Good idea, should be easy to integrate with https://hackage.haskell.org/package/tasty-golden
There was a problem hiding this comment.
I will try that in a separate PR. Thank you for the suggestion :)
alanz
approved these changes
Jun 8, 2020
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
+ Reduce manual duplication of information shared between hover and goto-def tests + Make sure that all the information in the test specifications that relates to fiddly line and column numbers, fits together on one screen, and is generally easier to match and understand by eye.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it OK to use "stylishHaskellCmd:" error message when the name of the plugin is "stylish-haskell"? All existing plugins have names without "-", so I couldn't find an example for this kind of naming.
Done: