Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonise logging #39

Closed
alanz opened this issue Feb 5, 2020 · 3 comments
Closed

harmonise logging #39

alanz opened this issue Feb 5, 2020 · 3 comments
Labels
old_type: meta Planing and organizing other issues type: enhancement New feature or request

Comments

@alanz
Copy link
Collaborator

alanz commented Feb 5, 2020

We seem to have a number of approaches to logging, spread over haskell-lsp, hie and ghcide.

I think there are two decisions we need to take

a) how and what are we going to log? Tapping into the LSP expectations makes sense, which seems to be to use stderr, which can then be managed per process and per client.

b) Which logging framework will we use? In my mind this should be common across haskell-lsp, ghcide, and hls. And that will drag hie in to match, but it should not necessarily be the driver for the decision.

@alanz alanz added type: support User support tickets, questions, help with setup etc. old_type: meta Planing and organizing other issues labels Feb 5, 2020
@alanz
Copy link
Collaborator Author

alanz commented Feb 6, 2020

I spoke to @ndmitchell today, I gather the logger in ghcide is an abstraction, it should be easy to instantiate it with the one already used in haskell-lsp etc.

This still leaves open what the logging policy should be.

@jneira jneira added type: refactor type: enhancement New feature or request and removed type: support User support tickets, questions, help with setup etc. labels Oct 21, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
Handle PackageImporting "this"
@teto
Copy link
Contributor

teto commented Apr 6, 2021

every message on stderr appears as an error in neovim logs (which kinda makes sense, it's stderr after all) but it makes finding actual errors harder.

@michaelpj
Copy link
Collaborator

Superseded by #2492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old_type: meta Planing and organizing other issues type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants