Skip to content

Add support for splice plugin with GHC 9.10 #6731

Add support for splice plugin with GHC 9.10

Add support for splice plugin with GHC 9.10 #6731

Triggered via pull request November 18, 2024 14:59
Status Failure
Total duration 50s
Artifacts

hlint.yml

on: pull_request
Hlint check run
41s
Hlint check run
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 15 warnings
Hlint check run: plugins/hls-splice-plugin/src/Ide/Plugin/Splice.hs#L220
Error in expandTHSplice in module Ide.Plugin.Splice: Avoid restricted function ▫︎ Found: "traceShow" ▫︎ Note: may break the code
Hlint check run: plugins/hls-splice-plugin/src/Ide/Plugin/Splice.hs#L225
Error in expandTHSplice in module Ide.Plugin.Splice: Avoid restricted function ▫︎ Found: "traceShowId" ▫︎ Note: may break the code
Hlint check run: plugins/hls-splice-plugin/src/Ide/Plugin/Splice.hs#L319
Error in pShow in module Ide.Plugin.Splice: Avoid restricted function ▫︎ Found: "unsafePerformIO" ▫︎ Note: may break the code
Hlint check run: plugins/hls-splice-plugin/src/Ide/Plugin/Splice.hs#L322
Error in pShowNoColor in module Ide.Plugin.Splice: Avoid restricted function ▫︎ Found: "unsafePerformIO" ▫︎ Note: may break the code
Hlint check run: plugins/hls-splice-plugin/src/Ide/Plugin/Splice.hs#L325
Error in traceFile in module Ide.Plugin.Splice: Avoid restricted function ▫︎ Found: "unsafePerformIO" ▫︎ Note: may break the code
Hlint check run
HLint failed with status: 1. Error (5), Warning (100), Suggestion (24)
Hlint check run
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Hlint check run
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Hlint check run: exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L636
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef' cradle_files (\\ xs -> (cfp : xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((:) cfp)"
Hlint check run: ghcide/session-loader/Development/IDE/Session.hs#L884
Suggestion in newComponentCache in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(homeUnitId_ (componentDynFlags ci)) `OS.member` bad_units" ▫︎ Perhaps: "homeUnitId_ (componentDynFlags ci) `OS.member` bad_units"
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
Hlint check run: ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L87
Warning in parseMultiCradleErr in module Development.IDE.Session.Diagnostics: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L72
Warning in module Development.IDE.Core.Compile: Use fewer imports ▫︎ Found: "import Development.IDE.Core.FileStore ( resetInterfaceStore )\nimport Development.IDE.Core.FileStore ( shareFilePath )\n" ▫︎ Perhaps: "import Development.IDE.Core.FileStore\n ( resetInterfaceStore, shareFilePath )\n"
Hlint check run: ghcide/src/Development/IDE/Core/Compile.hs#L960
Suggestion in getModSummaryFromImports in module Development.IDE.Core.Compile: Redundant bracket ▫︎ Found: "((ideclPkgQual i), reLoc $ ideclName i)" ▫︎ Perhaps: "(ideclPkgQual i, reLoc $ ideclName i)"
Hlint check run: ghcide/src/Development/IDE/Core/Rules.hs#L794
Suggestion in getModIfaceFromDiskRule in module Development.IDE.Core.Rules: Use fmap ▫︎ Found: "\\ fs -> map (snd . fromJust . hirCoreFp) <$> uses_ GetModIface fs" ▫︎ Perhaps: "fmap (map (snd . fromJust . hirCoreFp)) . uses_ GetModIface"
Hlint check run: ghcide/src/Development/IDE/Core/Rules.hs#L1067
Warning in getLinkableRule in module Development.IDE.Core.Rules: Use whenMaybe ▫︎ Found: "if exists then Just <$> getModTime obj_file else pure Nothing" ▫︎ Perhaps: "whenMaybe exists (getModTime obj_file)"
Hlint check run: ghcide/src/Development/IDE/GHC/Compat/Core.hs#L482
Warning in module Development.IDE.GHC.Compat.Core: Use fewer imports ▫︎ Found: "import GHC.Utils.Error ( Severity(..), emptyMessages )\nimport GHC.Utils.Error ( mkPlainErrorMsgEnvelope )\n" ▫︎ Perhaps: "import GHC.Utils.Error\n ( Severity(..), emptyMessages, mkPlainErrorMsgEnvelope )\n"
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/