This repository was archived by the owner on Jan 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 96
Populate ms_hs_date in GetModSummary rule #694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9afbbd6
to
42936ba
Compare
cocreature
reviewed
Jul 16, 2020
42936ba
to
91680da
Compare
1ceabcf
to
698ab6b
Compare
I extended this change in the following directions:
I tested the changes with the Eval plugin in haskell-language-server, branch: http://github.com/pepeiborra/ide/tree/eval Please take another look and let me know |
Benchmarks showing no perf regressions (in non-mingw): https://github.com/pepeiborra/ghcide/tree/getmodsummary-modtime-benchmarks/bench-hist
|
698ab6b
to
29bb521
Compare
cocreature
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me with two small comments.
29bb521
to
a273b5d
Compare
cocreature
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Populate ms_hs_date in GetModSummary rule * More faithful ModSummary timestamps * More ModSummary timestamps * Address duplication * Remove a displaced comment
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Populate ms_hs_date in GetModSummary rule * More faithful ModSummary timestamps * More ModSummary timestamps * Address duplication * Remove a displaced comment
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Populate ms_hs_date in GetModSummary rule * More faithful ModSummary timestamps * More ModSummary timestamps * Address duplication * Remove a displaced comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward fix that came up during haskell/haskell-language-server#191