Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using build-type Configure instead of Custom. #20

Closed
wants to merge 1 commit into from

Conversation

acw
Copy link

@acw acw commented Oct 24, 2014

Doing so allows for easier building on the HaLVM, as it doesn't require Cabal to
be smart about cross-compilers. The new configure script is a straightforward
reimplementation of the old Setup.hs semantics into autoconf form. Both the
configure.ac and configure form are included for simplicity.

Doing so allows for easier building on the HaLVM, as it doesn't require Cabal to
be smart about cross-compilers. The new configure script is a straightforward
reimplementation of the old Setup.hs semantics into autoconf form. Both the
configure.ac and configure form are included for simplicity.
@TomMD
Copy link
Collaborator

TomMD commented Oct 27, 2014

Can anyone confirm this works trivially on Windows (32/64)?

@neongreen
Copy link

On my computer (64bit Windows 7, 32bit compiler) it crashes conftest.exe.

@TomMD TomMD closed this May 18, 2015
@georgefst
Copy link

I know this is an old thread, but would you be interested in helping to try to revive this work? I have a large project I'm trying to cross-compile (x86-linux to aarch64-linux) where this library is the one remaining blocker. I'd like to see if this sort of approach can be made to work before I resort to -fexternal-interpreter etc.

At a glance, it looks like the custom setup here isn't doing anything which should be out of scope for autoconf?

@mergify
Copy link

mergify bot commented Apr 15, 2022

@georgefst is not allowed to run commands

georgefst added a commit to georgefst/wreq that referenced this pull request Apr 15, 2022
…rpreter`)

As it stands, we also need changes to `entropy`, but I'll manage that separately. Hopefully by reviving haskell/entropy#20.

Note that the custom setup is only used for `cabal-doctest`, so we really can just safely remove it. This is essentially the same issue as cdepillabout/pretty-simple#82.

Seeing as all the TH is just for `makeLenses`, in an ideal world we really ought to just be able to run on the host: see ghc-proposals/ghc-proposals#243.

The changes to the two `.hs` files are from dumping the TH splices (and manually (well, with _some_ help from HLS) adding a load of qualified imports). The splices can be found in `dist-newstyle` after adding this to `cabal.project`:

```
package wreq
    ghc-options: -ddump-splices -dth-dec-file
```
@georgefst
Copy link

georgefst commented Apr 15, 2022

Okay, it seems that simply disabling the custom setup is enough to get things to build, and, AFAICT, work.

Is the setup script not always necessary?

EDIT: See also #42.

@mergify
Copy link

mergify bot commented Apr 15, 2022

@georgefst is not allowed to run commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants