Make check recognise main-is in conditional branches
#9768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Mar 2, 2024
|
I am wondering: does it makes sense to add a changelog? This patch fixes a bug of the reimplementation, and the reimplementation will land in the yet-to-be-released |
|
If the currently released version doesn't have the bug, the changelog about fixing it is not needed imo. |
Kleidukos
reviewed
Mar 4, 2024
`main-is` not picked up when inside a multibranch CondNode.
Goes hand in hand with with simplifyCondTree.
`cabal check` had a problem recognising fields in presence of multiple branches. This patch fixes the problem and does not meaningfully increases CI time of particularly taxing tests (like “duplicate flagged dependencies” from MemoryUsage).
|
@mergify backport 3.12 |
✅ Backports have been created
|
mergify
bot
added
the
merge delay passed
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2024
* Add tests for #9742 `main-is` not picked up when inside a multibranch CondNode. * Fix comments * Add simplifyBranch to Distribution.Types.CondTree Goes hand in hand with with simplifyCondTree. * Make `check` deal correctly with multiple branches `cabal check` had a problem recognising fields in presence of multiple branches. This patch fixes the problem and does not meaningfully increases CI time of particularly taxing tests (like “duplicate flagged dependencies” from MemoryUsage). --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 74b1f21)
mergify bot
added a commit
that referenced
this pull request
Mar 11, 2024
Make `check` recognise `main-is` in conditional branches (backport #9768)
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Apr 22, 2024
* Add tests for haskell#9742 `main-is` not picked up when inside a multibranch CondNode. * Fix comments * Add simplifyBranch to Distribution.Types.CondTree Goes hand in hand with with simplifyCondTree. * Make `check` deal correctly with multiple branches `cabal check` had a problem recognising fields in presence of multiple branches. This patch fixes the problem and does not meaningfully increases CI time of particularly taxing tests (like “duplicate flagged dependencies” from MemoryUsage). --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9742.
Include the following checklist in your PR: