Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax containers upper bound in Cabal-syntax #9643

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jan 22, 2024

Closes #9603


Include the following checklist in your PR:

@mpickering mpickering added the merge me Tell Mergify Bot to merge label Jan 22, 2024
@mpickering
Copy link
Collaborator

Thanks @ffaf1

@Bodigrim
Copy link
Collaborator

I would expect other packages need a relaxation as well, at least Cabal, cabal-install-solver and cabal-install.

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jan 22, 2024

They were already bumped in 12eeb79

@ulysses4ever ulysses4ever changed the title Relax containers upper bound Relax containers upper bound in Cabal-syntax Jan 23, 2024
@bgamari bgamari merged commit ae3c40a into haskell:master Jan 23, 2024
47 checks passed
@ffaf1 ffaf1 deleted the containers branch January 23, 2024 21:16
@Mikolaj
Copy link
Member

Mikolaj commented Jan 23, 2024

@Bodigrim, @bgamari: do you need a backport of this to the soon to be released cabal-install 3.10.3 (note that GHC 9.10 will likely be accompanied by the current master, which will be 3.12.1)?

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jan 23, 2024

(note that of course that two patches would have to be picked, if this is going to be backported)

@Bodigrim
Copy link
Collaborator

do you need a backport of this to the soon to be released cabal-install 3.10.3?

It would not hurt and I imagine someone could benefit from it, but not a strong requirement. Might be easier to do it upfront than (potentially) revise later though.

@Mikolaj
Copy link
Member

Mikolaj commented Jan 23, 2024

(note that of course that two patches would have to be picked, if this is going to be backported)

Two PRs? Total? Doesn't sound too bad. Let's do it, I think.

@Mikolaj
Copy link
Member

Mikolaj commented Jan 23, 2024

BTW, we need to ask mergify to backport them in proper order or it'd create conflicts...

@geekosaur
Copy link
Collaborator

@mergify backport 3.10

Copy link
Contributor

mergify bot commented Jan 24, 2024

backport 3.10

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jan 24, 2024
Relax `containers` upper bound in `Cabal-syntax` (backport #9643)
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow containers-0.7
7 participants