Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeAbstractions extension #9502

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add TypeAbstractions extension #9502

merged 1 commit into from
Dec 12, 2023

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Dec 8, 2023

Towards #9496.

If needed, the correct cabal check behaviour can be backported to 3.10 without adding | TypeAbstractions constructor (a breaking change).

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!) We do not write tests on adding extensions.

QA Notes

  1. mkdir prova && cd prova
  2. cabal init -nm
  3. add a default-extensions: TypeAbstractions in the executable stanza
  4. cabal check should not complain with unknown-extension (compare with 3.10 where it does)

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! As noted by Andrea, a backport would need to be hacked specially, without adding the constructor that would violate PvP. (And, IMHO, having this in 3.10 is worth the extra effort, if we can afford it.)

ffaf1 added a commit to ffaf1/cabal that referenced this pull request Dec 8, 2023
See haskell#9496.

“Backport” of haskell#9502, notice that we are not adding a new constructor,
just tweaking `check` behaviour.  This is improve UX without breaking
changes.
@ffaf1 ffaf1 mentioned this pull request Dec 8, 2023
5 tasks
ffaf1 added a commit to ffaf1/cabal that referenced this pull request Dec 8, 2023
See haskell#9496.

“Backport” of haskell#9502, notice that we are not adding a new constructor,
just tweaking `check` behaviour.  This is improve UX without breaking
changes.
@ffaf1 ffaf1 added the merge me Tell Mergify Bot to merge label Dec 8, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 11, 2023
@mergify mergify bot merged commit 993481e into haskell:master Dec 12, 2023
49 checks passed
@ffaf1 ffaf1 deleted the add-extension branch December 12, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants