-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9318 Avoid Haddock warning with haddock --for-hackage
#9319
Conversation
Fourmolu doesn't think you folllowed the style closely enough, apparently. |
@geekosaur, sorry on formatting; trying again. |
@geekosaur, I think the CI is failing for reasons unconnected with this pull request (based, in part, on this comment: #9320 (comment) which refers to the same problem in terms that suggest it is a familiar problem). |
Oh, yes, the "directory-1.3.8.1 directory-1.3.8.1" CI problem strikes again. Let me restart the jobs and if everything else fails, I will wipe out CI cache. |
It failed in the same way. Let me clear the GHA cache. |
Clearing GHA cache of master branch with https://github.com/haskell/cabal/actions/caches fixed the issue this time. @mpilgrem: apologies for the inconvenience and thank you for the PR. ;) |
The logic of this change is simple: if the existing condition for the use of Haddock's
--hyperlinked-source
flag is met, don't also include the existing logic for the use of Haddock's--source-*
options.Include the following checklist in your PR:
Bonus points for added automated tests!