Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v2-prefix from Quickstart guide #9087

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Remove v2-prefix from Quickstart guide #9087

merged 2 commits into from
Jul 9, 2023

Conversation

tomjaguarpaw
Copy link
Member

@tomjaguarpaw tomjaguarpaw commented Jul 5, 2023 •
edited
Loading

Closes #9086

Please include the following checklist in your PR:

Seems irrelevant for a documentation PR

Deemed unnecessary

  • The documentation has been updated, if necessary.

It is the documentation

It doesn't

Bonus points for added automated tests!

Bonus points forgone

@tomjaguarpaw tomjaguarpaw mentioned this pull request Jul 5, 2023
Closed
ulysses4ever
ulysses4ever approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Jul 5, 2023
@ulysses4ever ulysses4ever mentioned this pull request Jul 5, 2023
Closed
@ulysses4ever
Copy link
Collaborator

I wonder if we need a changelog for this change though.

@ffaf1
Copy link
Collaborator

ffaf1 commented Jul 5, 2023

I wonder if we need a changelog for this change though.

Change is user visible, but it doesn’t document anything new.

@ulysses4ever
Copy link
Collaborator

Right. Perhaps it's fine...

@ulysses4ever ulysses4ever linked an issue Jul 5, 2023 that may be closed by this pull request
Update docs for 3.x release: remove v2- prefix and unflag as experimental #6213
Closed
@AphonicChaos AphonicChaos mentioned this pull request Jul 6, 2023
Merged
7 tasks
@tomjaguarpaw
Copy link
Member Author

I appear to have the ability to merge this, which surprises me! I didn't know I had any maintenance rights. Anyway, should I merge it then?

@ffaf1
Copy link
Collaborator

ffaf1 commented Jul 6, 2023 •
edited
Loading

Wait for the bot to do it (that merge me label). There is a 48h wait period , to allow other contributors to take a look and chime in, if they have something to say.

@ulysses4ever
Copy link
Collaborator

For the record, PR template (which is not supposed to be removed) had a reference to the contributing page, which has a section about merge process: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions

@tomjaguarpaw
Copy link
Member Author

The PR template didn't seem particularly relevant for documentation-only changes, and only refers to CONTRIBUTING.md as "coding conventions", so I didn't look at it. But I take the point that it is supposed to be included nonetheless, so I will do so.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 8, 2023
@ulysses4ever
Copy link
Collaborator

@mergify rebase

tomjaguarpaw and others added 2 commits July 9, 2023 13:48
@tomjaguarpaw @ulysses4ever
Remove v2-prefix from Quickstart guide
b3953e3 
Closes haskell#9086
@tomjaguarpaw @ulysses4ever
Clarify what build is
1f5c00d 
Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 15a5e3c into haskell:master Jul 9, 2023
43 checks passed
@ulysses4ever
Copy link
Collaborator

Documentation only -- good candidate for a backport imo

@ulysses4ever
Copy link
Collaborator

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 14, 2023
Merged
ulysses4ever added a commit that referenced this pull request Jul 14, 2023
@ulysses4ever
Remove v2-prefix from Quickstart guide (backport #9087) (#9124)
2c16e65 
Remove v2-prefix from Quickstart guide

Closes #9086

(cherry picked from commit b3953e3)

* Clarify what build is

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
(cherry picked from commit 1f5c00d)
mergify bot added a commit that referenced this pull request Jul 14, 2023
@mergify
Merge pull request #9124 from haskell/mergify/bp/3.10/pr-9087
36a7f2f 
Remove v2-prefix from Quickstart guide (backport #9087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
3 participants
@tomjaguarpaw @ulysses4ever @ffaf1