Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future-proof against potential Prelude.foldl' #8960

Merged
merged 1 commit into from
May 25, 2023
Merged

Future-proof against potential Prelude.foldl' #8960

merged 1 commit into from
May 25, 2023

Conversation

Bodigrim
Copy link
Collaborator

See haskell/core-libraries-committee#167

This is, of course, a bit speculative at the moment, but given that the change does not involve CPP, it should not hurt to merge it early to simplify further impact assessment.

@ulysses4ever
Copy link
Collaborator

Thank you for taking the time to prepare the fix. Did you check that it works with a patched version of base?

@Bodigrim
Copy link
Collaborator Author

Yes, I built GHC with patched base and used it to compile Cabal-syntax.

ffaf1
ffaf1 approved these changes May 20, 2023
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome addition.

@Bodigrim Bodigrim added the merge me Tell Mergify Bot to merge label May 20, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 22, 2023
@Bodigrim
Copy link
Collaborator Author

This pull request cannot be embarked for merge
Unable to update: user Bodigrim is unknown.
Please make sure Bodigrim has logged in Mergify dashboard.

I'm not sure what this is supposed to mean. Could someone please merge it manually?

@ulysses4ever
Copy link
Collaborator

@Bodigrim indeed. I'm sorry for all the delays..

@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

rebase

✅ Branch has been successfully rebased

@ulysses4ever
Copy link
Collaborator

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 1993128 into master May 25, 2023
@mergify mergify bot deleted the foldl-prime-in-prelude branch May 25, 2023 23:35
@ulysses4ever
Copy link
Collaborator

Merged! Thanks again Andrew!

@Bodigrim
Copy link
Collaborator Author

It's not strictly necessary, but could this possibly be backported to 3.10 branch? So that both GHC HEAD (which requires this patch) and GHC 9.8 branch could point to the same Cabal commit.

@Mikolaj
Copy link
Member

Mikolaj commented Sep 16, 2023

Let me try an automatic backport and leave it to the release manager (@Kleidukos) to decide whether to delay the release yet a bit more.

@Mikolaj
Copy link
Member

Mikolaj commented Sep 16, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2023 •
edited
Loading

backport 3.10

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 16, 2023
Merged
@Bodigrim
Copy link
Collaborator Author

Bodigrim commented Sep 16, 2023 •
edited
Loading

Oh, sorry, if it causes a delay then it might be not worth it. This is really a minor thing.

Kleidukos pushed a commit that referenced this pull request Sep 18, 2023
@mergify @Bodigrim
Future-proof against potential Prelude.foldl' (backport #8960) (#9265)
720b6b1 
Co-authored-by: Bodigrim <andrew.lelechenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bodigrim @ulysses4ever @Mikolaj @ffaf1