Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't auto-download in hash validation phase #8769

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

gbaz
Copy link
Collaborator

@gbaz gbaz commented Feb 15, 2023

Resolves #8708 and #8706

Sorry, no additional regression test for this.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 15, 2023

Sorry, no additional regression test for this.

@jneira will be unamused.

@jneira
Copy link
Member

jneira commented Feb 15, 2023

well, let's register the debt with a label 😉

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice but the regression is pretty bad, and the earlier we merge a fix the better.

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Feb 15, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Feb 15, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2023

backport 3.10

✅ Backports have been created

@Mikolaj
Copy link
Member

Mikolaj commented Feb 15, 2023

Let me set the label and the backport in the interest of swiftness. We still have 2 days to add a test.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-test merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected downloads with cabal repl in 3.9 prerelease
4 participants