Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds defaultMainWithHooksNoReadArgs #4859

Merged

Conversation

angerman
Copy link
Collaborator

@angerman angerman commented Nov 3, 2017

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

@@ -138,6 +138,12 @@ defaultMainWithHooksNoRead hooks pkg_descr =
getArgs >>=
defaultMainHelper hooks { readDesc = return (Just pkg_descr) }

-- | A customizable version of 'defaultMainNoRead' that also takes the
-- command line arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a @since annotation. Otherwise OK.

@23Skidoo 23Skidoo merged commit 5cc8755 into haskell:master Nov 3, 2017
@23Skidoo
Copy link
Member

23Skidoo commented Nov 3, 2017

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants