Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to exclude generated modules from sdists #1046

Closed
wants to merge 2 commits into from

Conversation

lpotmann
Copy link

In one of my projects, I am machine-generating a number of modules, which other parts of the code then import. These need to be specified in the .cabal file, otherwise hard-to-debug linker errors happen. However, then they get included in sdist tarballs, or sdist chokes if they're not present, which is undesirable. This patch lets generated modules be excluded from sdists on the command line with a --generated-module option.

(An alternative (and perhaps more robust) approach would be to add a generated-modules field to cabal files, but that's only just occurred to me and this patch is sitting here!)

@23Skidoo
Copy link
Member

Can't you use the same trick as @dcoutts described in #1557 (generate a .buildinfo and list your generated modules there)?

@tibbe
Copy link
Member

tibbe commented Dec 19, 2013

I definitely think we should go with generated-modules. We ought to track these regardless as e.g. distributed builds won't work otherwise.

@tibbe
Copy link
Member

tibbe commented Apr 7, 2014

@lpotmann I'd like to see generated-modules. Are you interested in working on that?

@ttuegel
Copy link
Member

ttuegel commented Sep 20, 2015

I'm going to close this because it's pretty clear that this belongs in a generated-modules field of the package description (it's static configuration data, not something that can change at runtime).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants