Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep running tests even if earlier ones failed #10361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geekosaur
Copy link
Collaborator

Matt Pickering says we should always run all tests. This uses continue-on-error: true to run them as long as the build succeeded.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ffaf1
Copy link
Collaborator

ffaf1 commented Sep 16, 2024

Aren't we going to saturate CI resources pretty fast this way?

@geekosaur
Copy link
Collaborator Author

geekosaur commented Sep 16, 2024

Yes, as I observed with #10291. But see #10263; @mpickering is insisting it's necessary.

Matt Pickering says we should always run all tests. This uses
`continue-on-error: true` to run them as long as the build
succeeded.
Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants