Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning and note about cabal init and script #10327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add warning and note about cabal init and script #10327

wants to merge 1 commit into from
+34 −1

Conversation

philderbeast
Copy link
Collaborator

Fixes #10325.

@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from b7a0613 to da2154a Compare September 9, 2024 13:17
@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from d8c1e64 to 8438aff Compare September 9, 2024 14:18
@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from 6f8b313 to 08adfbb Compare September 10, 2024 11:16
@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from 08adfbb to 85aa234 Compare September 11, 2024 13:32
@philderbeast
Copy link
Collaborator Author

@ulysses4ever I committed your suggested change, squashed and rebased. This is ready for another review.

@ulysses4ever
Copy link
Collaborator

@philderbeast yes, thank you! It's on my radar. I'm kinda curious what others think. I'm still unsure it's a good idea to pull this topic in the getiing-started. I wanted to sit on my thoughts till the end of the week and then get back to you. Sorry for the delay!

@geekosaur
Copy link
Collaborator

I think it's a good idea, as it's a common "gotcha" for newcomers as indicated by how often it comes up in e.g. Libera #haskell.

@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from 85aa234 to 9082db8 Compare September 11, 2024 17:24
@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from 9082db8 to e8a4029 Compare September 22, 2024 14:11
ulysses4ever
ulysses4ever approved these changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulysses4ever ulysses4ever added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Sep 22, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 22, 2024
@philderbeast
Copy link
Collaborator Author

Thanks for the approval @ulysses4ever. Can we use squash+merge me now with a pull request from an organisation?

Label merge+no rebase is necessary when the pull request is from an organisation.

@geekosaur
Copy link
Collaborator

No, this hasn't changed; if the organization doesn't permit people outside it access, it will require the merge+no rebase label. This is an organization security/permissions setting.

@philderbeast @ulysses4ever
Add warning and note about cabal init and script
0126825 
Fixes haskell#10325

- Simplify note on relaxing version bounds
- Link to GHC release note included or boot packages
- May allow, not will allow
- Add a second link to footnote on boot packages

Co-Authored-By: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
@philderbeast philderbeast force-pushed the doc/cabal-init-script-version-bounds-10325 branch from e8a4029 to 0126825 Compare September 22, 2024 17:25
@philderbeast philderbeast added merge+no rebase and removed squash+merge me Tell Mergify Bot to squash-merge labels Sep 22, 2024
@philderbeast
Copy link
Collaborator Author

Thanks @geekosaur. I manually squashed and swapped labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs script example doesn't run with ghc-9.10.1
3 participants
@philderbeast @ulysses4ever @geekosaur