Fix shutdown crash when log/error callback is set #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rd_kafka_destroy method may call back into Haskell to perform some logging. This is not allowed when attaching the finalizer using Foreign.ForeignPtr. Hence we switch to Foreign.Concurrent, which allows RdKafka to call back into Haskell. We also disable closing the consumer automatically in the finalizer, this should be done by the application by calling `closeConsumer` explicitly.
|
Using our test-suite I could reliably reproduce the |
|
The CI errors seems to be because it uses a librdkafka version from March 2018, but |
|
Thanks a lot! It was a long standing issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rd_kafka_destroy method may call back into Haskell to perform some logging. This is not allowed when attaching the finalizer
using Foreign.ForeignPtr. Hence we switch to Foreign.Concurrent, which allows RdKafka to call back into Haskell. We also disable
closing the consumer automatically in the finalizer, this should be done by the application by calling
closeConsumerexplicitly.