Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats/socket callback types #166

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

phile314
Copy link
Contributor

@phile314 phile314 commented Jan 4, 2021

See #165 .

I ran my program with these changes for ~30 minutes and everything worked as it should.

@AlexeyRaga
Copy link
Member

Thanks, looks good!
Do you know if we should do the same for all the other callbacks that we have here? Like, log callback, offsets committed callback, rebalance callback etc.?
Or the issue is specific for stats callback?

@phile314
Copy link
Contributor Author

phile314 commented Jan 4, 2021

The issue is specific to the stats/socket callback. I checked the other callbacks and I didn't see any issues there:

-rebalance
-delivery
-consume
-offset_commit
-error
-partitioner

I think that covers all callbacks in hw-kafka-client.

@AlexeyRaga
Copy link
Member

Thanks @phile314 ! Very appreciated!

@AlexeyRaga AlexeyRaga merged commit 5049adb into haskell-works:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants