Add a consumer option to rely on users for polling. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it just "reduces the number of duplicates" or it fixes the issue? |
AlexeyRaga
reviewed
Sep 5, 2019
| @@ -36,11 +38,12 @@ data ConsumerProperties = ConsumerProperties | |||
| { cpProps :: Map Text Text | |||
| , cpLogLevel :: Maybe KafkaLogLevel | |||
| , cpCallbacks :: [KafkaConf -> IO ()] | |||
| , cpUserPolls :: Any | |||
There was a problem hiding this comment.
Using Any means that once stitched on it can never be switched off. It could be confusing, so can we have just Bool or Last Bool?
AlexeyRaga
reviewed
Sep 5, 2019
| -- in a background thread, with this property set you can simplify | ||
| -- hw-kafka-client's footprint and have full control over when polling | ||
| -- happens at the cost of having to manage this yourself. | ||
| userPolls :: ConsumerProperties |
There was a problem hiding this comment.
The name userPolls kind of suggests that user should somehow poll manually.
Should we instead do something like:
data CallbackMode = CallbackModeAsync | CallbackModeSync
callbackMode :: CallbackMode -> ConsumerProperties
It looks a bit more explicit to me, do you agree?
AlexeyRaga
reviewed
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been hitting a lot of issues with the background poll thread causing commit errors and large numbers of duplicate messages. I'm not sure how to fix it (see #107 for an attempt), but this change dramatically reduces the number of duplicate messages/commit errors we see in our test harness in a backwards-compatible way.