Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity entity capabilities path #9958

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Conversation

chelshaw
Copy link
Contributor

This issue was causing a bug where the capabilities on an identity/entity model had the incorrect updatePath due to identityType not properly being passed into the apiPath method. This change hardcodes the path for the entity model, since by the model's own definition the type is entity.

Investigation is still needed for why the computed property was not being passed into the apiPath method properly, but this should fix adverse side affects such as tokens with policy including the path identity/entity/id/* not having the correct options on an entity dropdown.

Sample policy:

path "identity/entity/id/*"
{
  capabilities = ["list", "read", "delete", "sudo", "create", "update"]
}

has-sample-policy

@chelshaw chelshaw added ui bug Used to indicate a potential bug labels Sep 15, 2020
@chelshaw chelshaw added this to the 1.5.4 milestone Sep 15, 2020
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick fix.

@chelshaw chelshaw merged commit 4b0e023 into master Sep 16, 2020
@chelshaw chelshaw deleted the ui/fix-capabilities-path-entity branch September 16, 2020 19:06
@chelshaw chelshaw removed this from the 1.5.4 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants