Migrate to azure-storage-blob-go #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@briankassouf or @kalafut Can you please have a look? I left two |
|
@calvn Just rebased again. Can you have a look please? |
calvn
reviewed
Sep 25, 2020
calvn
reviewed
Oct 1, 2020
calvn
reviewed
Oct 1, 2020
The azure sdk for go is maintenance-only for storage, see https://github.com/Azure/azure-sdk-for-go/tree/master/storage\#azure-storage-sdk-for-go-preview Migrate to new azure-storage-blob-go SDK Minor test improvements Fix #9661
|
@calvn I believe all comments have been addressed |
calvn
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Ran acceptance tests and they passed. The listing test took a bit since it needs to create 5k+ keys on the storage container for that test case.
=== RUN TestAzureBackend
--- PASS: TestAzureBackend (1.88s)
=== RUN TestAzureBackend_ListPaging
--- PASS: TestAzureBackend_ListPaging (235.04s)
PASS
That's great!! Can we merge it then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The azure sdk for go is maintenance-only for storage, see https://github.com/Azure/azure-sdk-for-go/tree/master/storage\#azure-storage-sdk-for-go-preview
Migrate to new azure-storage-blob-go SDK
Minor test improvements