Ui search select fix #7338
Merged
Ui search select fix #7338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
approved these changes
Aug 22, 2019
| @@ -101,7 +101,7 @@ | |||
| "ember-load-initializers": "^2.0.0", | |||
| "ember-maybe-import-regenerator": "^0.1.6", | |||
| "ember-maybe-in-element": "^0.4.0", | |||
| "ember-power-select-with-create": "cibernox/ember-power-select-with-create#6203918f247c1c5d692db4f9185ab8321d2125e1", | |||
| "ember-power-select-with-create": "^0.6.2", | |||
There was a problem hiding this comment.
I don't think we'll be able to backport the upgrade, but the same code fixes should still work
meirish
added a commit
that referenced
this pull request
Aug 22, 2019
* guard against options and model not being defined * add test for select with no options
meirish
added a commit
that referenced
this pull request
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression where if there were no options, the error would get swallowed in a try/catch and we wouldn't show the add option.
Returning early when there are no
optionsavoids the error.This also updates
ember-power-select-with-createto the latest release, and fixes some errors I encountered when clicking theCancellink on the identity edit form.